i18next / i18next / 39997461512

96%

push

github

fix: format values when cached formatter options are not serializable (#2457)

With the default cacheInBuiltFormats: true, the cached formatter builds its
cache key with JSON.stringify over all t() options. A BigInt value or a
circular object anywhere in the options makes JSON.stringify throw, which
Formatter.format catches and logs, so every built-in format in that call
returns the raw value (e.g. 'Total: 12345678901234567890' instead of
'Total: 12,345,678,901,234,567,890').

When the key cannot be built, format without the cache, as
cacheInBuiltFormats: false already does.

1328 of 1470 branches covered (90.34%)

3 of 3 new or added lines in 1 file covered. (100.0%)

1298 of 1362 relevant lines covered (95.3%)

1988.89 hits per line