• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

Eyevinn / mp4ff / 39973519902
83%
master: 85%

Build:
Build:
LAST BUILD BRANCH: fix/crop-tables
DEFAULT BRANCH: master
Ran 23 Oct 2026 02:54PM UTC
Jobs 1
Files 221
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

23 Oct 2026 02:52PM UTC coverage: 82.925% (+0.07%) from 82.855%
39973519902

Pull #666

github

tobbee
fix(mp4): stop decoding panics on tracks and trafs that lack boxes

DecodeFile, DecodeFileSR and FragmentDecoder look up the track of an
encrypted traf with MoovBox.IsEncrypted and GetSinf to find the per-sample
IV size of its senc. Both dereferenced the tkhd, mdia, minf, stbl and stsd
of every trak, and the first stsd child, without checks. A moov track that
lacks one of those boxes, or has an empty stsd, made decoding panic. Such a
track is now skipped and counts as not encrypted, so its senc is parsed as
when there is no moov.

InitDecodeStream read the stts of the first track through mdia, minf and
stbl without checks, and panicked on a moov without a track or with a
first track missing one of those boxes. It now returns an error. The same
guarded check in File.AddChild moves to a shared helper.

TrafBox.ParseReadSenc, which the decoders call for an unparsed senc,
indexed the first saio offset and the first seig sgpd entry without
checking that they exist. A saio without offsets is now handled as no saio,
and a seig sgpd without entries gives an error.

A traf without tfhd panics on the same decoding path; #664 handles that.

The cases were found by renaming one box type to free in testdata files
and decoding the result.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01At28EcpTrbTU5CXRWWUhM1
Pull Request #666: fix(mp4): stop decoding panics on tracks and trafs that lack boxes

31 of 33 new or added lines in 4 files covered. (93.94%)

24113 of 29078 relevant lines covered (82.93%)

0.83 hits per line

Uncovered Changes

Lines Coverage ∆ File
2
88.56
0.17% mp4/traf.go
Jobs
ID Job ID Ran Files Coverage
1 39973519902.1 23 Oct 2026 02:54PM UTC 221
82.93
GitHub Action Run
Source Files on build 39973519902
  • Tree
  • List 221
  • Changed 6
  • Source Changed 0
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Pull Request #666
  • PR Base - master (#39493767376)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc