pomerium / pomerium / 39967880512

54%

Build Type

push

github

Committed by web-flow

Commit Message

test: testutil provide temporary tracker for health statuses (#6897)

## Summary

For historical reasons, the health manager / tracker implementations
follow a singleton pattern, with a push-style health status mechanism.

This doesn't play well with tests (and can cause tests to flake), since
they all share the same manager instance. The new testutil library
`healthtest` works around this problem, by registering a temporary
provider and tracker that watch for `test-id=<uuid>` attributes on
health checks.

I would recommend against writing tests for health checks in every test
suite, as they will cause updates to propagate to all registered
providers which might cause some performance or timing issues. But in
general this is probably OK to use where it makes sense.

Adds the fix to cluster follower test that tests health checks.

## Related issues

N/A

## User Explanation

N/A

## AI disclosure

opus 5.5 bootstrapped the pretty obvious self-test in
`internal/testutil/healthtest/health_test.go`. I made some small
adjustments to that. Otherwise, no AI was used either in the design or
implementation or other test changes.

## Checklist

- [X] reference any related issues
- [X] updated unit tests
- [X] add appropriate label (`enhancement`, `bug`, `breaking`,
`dependencies`, `ci`)
- [X] disclosed AI usage (or wrote "none") per AI_POLICY.md
- [X] ready for review

Coverage Stats

59 of 59 new or added lines in 2 files covered. (100.0%)

28 existing lines in 10 files now uncovered.

35259 of 65568 relevant lines covered (53.77%)

314.3 hits per line