supabase / supabase-flutter / 39966257653

93%

Build Type

push

github

Committed by web-flow

Commit Message

fix(postgrest)!: stop transforms from silently changing or dropping part of a request (#2026)

Linear:
https://linear.app/supabase/issue/SDK-2333/fixpostgrest-transforms-that-silently-change-or-drop-part-of-a-request

## What changed

Six builder methods compiled but sent something other than what was
asked for. Each one now either sends the right request or fails at the
call site.

1. **`head()` after a write.** It used to turn an insert, upsert, update
or delete into a `HEAD`, so the write never happened and the call still
succeeded. Both surfaces now throw a `StateError` when `head()` is
called after a write. A select, a count and a function call still send a
`HEAD`.
2. **`maybeSingle()` on a write.** An insert, upsert, update or delete
now sends `Accept: application/vnd.pgrst.object+json`, as `single()`
does. A delete or update that matches several rows is rolled back by
PostgREST before the error reaches the caller. Before, it was committed
and then the call threw. The 406 that PostgREST returns when no row
matched is turned back into `null` (count `0`). Reads and function calls
still enforce the limit client-side, so a read that finds nothing does
not cause a 406. `single()` after `maybeSingle()` clears the flag, so a
zero-row result still throws `PGRST116`.
3. **Typed `count()`.** It returns a new `PostgrestTypedCountBuilder`
with `where()` and the request options (`retry`, `requestTimeout`,
`abortSignal`, `setHeader`) but no transforms. `limit()` and `range()`
used to be dropped silently, and `csv()`, `select()` and `explain()`
crashed with a null check error. `PostgrestHttpTableExecutor` also
rejects a hand-built count request that carries a limit, offset,
ordering, embed scope or result shape.
4. **Untyped `rpc(...).head()`.** The arguments are moved into the query
string, which the typed executor already did. A `HEAD` has no body to
fall back on, so on both surfaces `head()` throws an `ArgumentError` for
arguments PostgREST would not pass t... (continued)

Coverage Stats

90 of 96 new or added lines in 10 files covered. (93.75%)

53 existing lines in 2 files now uncovered.

11592 of 12554 relevant lines covered (92.34%)

6.07 hits per line