trickstercache / trickster / 39930892169

94%

main: 94%

Build Type

Pull #1213

github

Committed by thinker0

Commit Message

fix(dpc): recover from timeseries cache unmarshaling failure

When reading a cached timeseries from a non-chunking cache (such as
Redis), if the cached payload cannot be unmarshaled (e.g. legacy point
layout ErrLegacySeries or corrupted bytes), QueryCache was discarding
the unmarshal error and returning a partially-populated DataSet with
pre-populated ExtentList. This caused DeltaProxyCache to treat the entry
as a partial hit with phantom coverage, suppressing origin fetches and
returning empty results.

1. In dataset.UnmarshalDataSet and ReadDataSet, return (nil, err) on
   unmarshaling failure instead of returning a partially-populated DataSet.
2. In queryCache, propagate the unmarshaler error so that
   DeltaProxyCacheRequest detects the failure, purges the invalid cache entry
   via cache.Remove, and recovers by fetching fresh data from the origin.
3. Add TestDeltaProxyCacheUnmarshalingFailureRecovery regression test.

Signed-off-by: thinker0 <thinker0@gmail.com>
Co-authored-by: Gemini <noreply@google.com>

Pull Request Pull Request #1213: fix(dpc): recover from timeseries cache unmarshaling failure

Coverage Stats

11 of 11 new or added lines in 2 files covered. (100.0%)

16 existing lines in 6 files now uncovered.

99013 of 105638 relevant lines covered (93.73%)

15551.72 hits per line