supabase / supabase-flutter / 39932128141

94%

push

github

refactor(postgrest)!: hide internals and align the untyped builder with the typed one (#2029)

Linear:
https://linear.app/supabase/issue/SDK-2346/refactorpostgrest-hide-internals-and-align-the-untyped-builder-with

Closes the five postgrest findings from the v3 review.

## Changes

- **Untyped `abortSignal()` keeps the chain.**
`PostgrestTransformBuilder` and `PostgrestFilterBuilder` override
`abortSignal()` like they already did for `retry()`, `requestTimeout()`
and `setHeader()`, so filters and transforms can follow it.
`PostgrestQueryBuilder` gains `abortSignal()`, matching
`PostgrestTypedQueryBuilder`.
- **`copyWithUrl` is private.** It was public on
`PostgrestFilterBuilder` and `PostgrestTransformBuilder` and let a
caller point a request, auth headers included, at any URL. It is now
`_copyWithUrl`. MIGRATION.md lists the removal in the stateless builders
table, since it was public in v2.
- **`embeddedFilterName` is removed**, together with the private
`_filterName` chain that only it read. Embedded filtering is not on the
typed surface, so nothing consumed it.
- **Untyped `rpc` takes any body.** `PostgrestRpc.call` takes `Object?
params` instead of `Map? params`, like the builder underneath and the
typed `rows` and `value`. A function whose only parameter is an unnamed
`json` or `jsonb` can now get a list or a scalar. A `get: true` call
takes a map or no params at all, and throws `ArgumentError` on anything
else. Before, it also rejected a call without params, which the typed
`rows` and `value` accept.
- **An `Update` of `Never` blocks `delete()`.** The typed `delete()`
moved from `PostgrestTypedQueryBuilder` into two extensions.
`PostgrestTypedDelete` provides it for every table.
`PostgrestTypedReadOnlyDelete` applies to
`PostgrestTypedQueryBuilder<Row, Insert, Never>`, and because it is more
specific, Dart picks it for those tables. Its `delete(Never)` cannot be
called, so `delete().all()` on a read-only view no longer compiles. This
is the sam... (continued)

52 of 52 new or added lines in 5 files covered. (100.0%)

11251 of 12237 relevant lines covered (91.94%)

5.62 hits per line