• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

valkyrjaio / sindri-php / 39900916308
100%

Build:
DEFAULT BRANCH: 26.x
Ran 23 Oct 2026 04:34AM UTC
Jobs 1
Files 95
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

23 Oct 2026 04:33AM UTC coverage: 100.0%. Remained the same
39900916308

push

github

web-flow
[Ast] feat!: Read the renamed gRPC route attribute and its whole field set (#361)

# Description

Read the gRPC route attribute under its new name, and read every
argument it now takes. The
framework names the attribute `Route`, names its handler attribute
`RouteHandler`, and gives the
attribute a handler argument and one middleware list for each stage. The
generated cache has to
mirror what reflection collects, so a generator that reads the old names
and only part of the
field set emits a route the runtime collector would not build.

The reader also stops inferring a handler from the attributed method,
and rejects a route that
names none, because the runtime collector rejects it too.

This needs the framework release that ships the renamed attribute. The
`valkyrja/valkyrja`
constraint still admits a release that carries the old names, under
which a gRPC route would drop
out of the generated cache with no error, so the constraint moves to
that release before this
merges.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [ ] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [x] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Ast/GrpcRouteAttributeReader.php`** — reads the renamed attributes,
the handler argument and
the five middleware stage lists, and rejects a route that names no
handler
- **`Ast/Throwable/Exception/AstNoRouteHandlerException.php`** — the
failure the reader reports
- **`Ast/Contract/GrpcRouteAttributeReaderContract.php`** — declares the
failures `readFile` raises
- **`tests/`** — the fixtures name their handlers, one middleware
fixture serves each stage, and
new tests cover the stage lists by name and by position, the appended
`#[Middleware]`, a repeated
route attribute, a list... (continued)

27 of 27 new or added lines in 2 files covered. (100.0%)

2101 of 2101 relevant lines covered (100.0%)

21.27 hits per line

Jobs
ID Job ID Ran Files Coverage
1 39900916308.1 23 Oct 2026 04:34AM UTC 95
100.0
GitHub Action Run
Source Files on build 39900916308
  • Tree
  • List 95
  • Changed 4
  • Source Changed 4
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #39900916308
  • ad10ae0b on github
  • Prev Build on 26.x (#39886841940)
  • Next Build on 26.x (#39901131319)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc