thumbor / remotecv / 39880433329

94%

push

github

Harden the healthcheck HTTP server (#120)

The healthcheck used HTTPServer, which handles one connection at a time,
with no socket timeout on the handler, so a single client that opened a TCP
connection and never sent a request line blocked every probe until it went
away; in Kubernetes that turns one idle socket into a liveness failure and a
pod restart. The log_message override also skipped the control character
escaping the stdlib handler applies (3.12, and later 3.10 and 3.11 patch
releases), letting raw terminal escapes from the request line into the log,
and the Server header advertised the Python version.

The server is now a ThreadingHTTPServer with a 5 second handler timeout, log
lines are escaped the same way the stdlib does it, the Server header is just
"remotecv", and a new --server-host (HTTP_SERVER_HOST) option controls the bind
address. An IPv6 literal, with or without brackets, switches the socket to
IPv6. The default stays 0.0.0.0 because probes from kubelet reach the pod IP,
not loopback; operators on shared hosts can narrow it. start_http_server now
returns the server so tests can bind to port 0. This change is stacked on #116
and should merge after it.

22 of 22 new or added lines in 2 files covered. (100.0%)

560 of 635 relevant lines covered (88.19%)

4.41 hits per line