astronomer / astro-cli / 39825924031

61%

main: 45%

push

github

Align the remaining APC command behaviour with Astro: confirmation prompts and Astro's flag spellings (#2414)

* Align the remaining APC command behaviour with Astro

Confirm APC's destructive commands the way Astro does: astro workspace
delete, workspace service-account delete and deployment service-account
delete ask first and take --yes/-y, refusing under -o json without it.
astro organization team delete on Astro now asks about every team, not
only an IdP-managed one, which the audit of destructive commands found.

Take Astro's spellings, keeping each 1.x one working as a hidden alias:
--name/-n on workspace create/update (--label/-l), --keyword/-k on the
deployment logs commands (--search/-s), Astro's executor names on
deployment create/update, and the email or team id as the argument of
the APC user add and team add commands.

The --name question for deployment create/update is left open.

Co-Authored-By: Claude <noreply@anthropic.com>

* Clear the token ids a test run leaves, so a later test looks tokens up by name

The token id commands keep a positional argument in a package variable
that nothing resets. The JSON token tests cleared it before each run but
not after, so under -shuffle the last one could leave tok-ws behind, and
TestWorkspaceTokenAddAndRemovePickInTheWorkspaceTheyArePointedAt then took
the by-id path instead of the lookup by name it checks. This failed
test-windows on v2 too. Clear the ids after each JSON run as well, and at
the start of the cases that depend on them being empty.

Co-Authored-By: Claude <noreply@anthropic.com>

* Refuse a team delete that cannot ask before reading the team, and say when one is declined

From review. astro organization team delete under -o json without --yes
now refuses before it lists or reads a team, as astro workspace delete
does, so a bad id or a login problem does not stand in for the refusal.
A declined delete prints "Canceling team deletion" rather than nothing.

The APC user and team add... (continued)

121 of 128 new or added lines in 15 files covered. (94.53%)

41619 of 68630 relevant lines covered (60.64%)

409.61 hits per line