umputun / revdiff / 39823831483

92%

master: 91%

push

github

fix(ui): page only through hunks at least as tall as the viewport

paging had no height check, so a short hunk left partly off screen by j,
a search jump or a click made ] scroll a couple of rows instead of moving
to the next hunk, and [ from an 18-line hunk centered by ] scrolled one row
instead of going to the previous stop. Paging now needs the hunk to be at
least as tall as the viewport, the same test [ uses when it moves onto an
earlier hunk; ] already shows any shorter hunk whole when it moves onto it.

buildHunkLayout derives line heights from the offsets instead of computing
each one twice. A new test pins that a page step which keeps the cursor on
the same line does not cross files, and the backlog item about the
delete-only guard points at its current locations.

Related to #405

11 of 11 new or added lines in 1 file covered. (100.0%)

12231 of 13365 relevant lines covered (91.52%)

3472.86 hits per line