uc-cdis / multihead-workspace-proxy / 39823157802

11%

master: 5%

Build Type

Pull #12

github

Committed by jawadqur

Commit Message

fix: route to hatchery's ambassador annotation target

Hatchery records each workspace's routing target in the Service's
getambassador.io/config annotation. For ECS workspaces that target is an
internal ALB, and for external/GPU nodes it is a NodeIP:NodePort. Those
Services have no in-cluster endpoints, so routing to the Service's cluster
DNS name returns 502.

resolveUpstream now prefers the annotation's "service: host:port" (https when
"tls: true") and falls back to the cluster DNS name when it is absent or
invalid. Also drop a default port from the upstream Host and websocket
Origin: ALBs strip it from Host, so Jupyter rejected kernel websockets with
403.

Pull Request Pull Request #12: fix: route to hatchery's ambassador annotation target

Coverage Stats

39 of 40 new or added lines in 3 files covered. (97.5%)

14 existing lines in 1 file now uncovered.

231 of 2463 relevant lines covered (9.38%)

0.95 hits per line