ArduPilot / MethodicConfigurator / 39807708602

94%

push

github

fix(mavftp): tolerate slow 57600-baud telemetry links

USB-oriented MAVFTP timing can cause premature retries and parameter
download failures when radio buffering and competing telemetry delay
valid replies.

Adjust automatic defaults for serial links at or below 57600 baud:
- Increase the parameter download budget from 40 to 120 seconds.
- Increase the retransmission timeout floor from 0.5 to 2 seconds.
- Increase the read retry interval from 1 to 3 seconds.
- Increase the idle detection threshold from 3.7 to 10 seconds.
- Allow session cleanup to respect the configured retry floor instead
  of imposing the previous one-second cap.

Count accepted reply progress as link activity so a long incoming burst
does not trigger idle detection simply because no new request was sent.
Duplicate and foreign packets must not extend the inactivity window.

Preserve existing defaults for 115200-baud and network connections,
explicit FTP settings, and caller-supplied response timeouts.

Add regression coverage for delayed opens, transfers exceeding the
previous 40-second budget, delayed cleanup, bounded failure on silent
links, and duplicate or foreign traffic.

Signed-off-by: Dr.-Ing. Amilcar do Carmo Lucas <amilcar.lucas@iav.de>

7601 of 8724 branches covered (87.13%)

27106 of 28993 relevant lines covered (93.49%)

2.79 hits per line