mathieuprog / polymorphic_embed / d74e2b2a7c90463340fbc83714dfc46d9b6b4134-PR-148

86%

master: 83%

Build Type

Pull #148

github

Committed by nduitz

Commit Message

Build polymorphic embed forms as phoenix_ecto does

PolymorphicEmbed.HTML.Helpers.to_form/4 now follows the rules that
phoenix_ecto uses for embeds_one and embeds_many:

- A child form uses the child changeset from changes, with its own
  params and its own action. Before, row 0 of a list got the params of
  all rows, and each changeset got the parent action.
- The form errors follow the parent action, and valid? does not change.
- form.hidden contains the primary key of the data, as in phoenix_ecto,
  and the type field.
- Without a change, a form is built with the changeset function, which
  the cast stores as on_cast in the embed type.

Two existing tests asserted the old output. The list test now expects
the value of the first row, as for the regular embed. The nil embed test
now expects the errors of the new SMS changeset, as for an Ecto embed.

All form parity tests pass.

Pull Request Pull Request #148: Ecto parity

Coverage Stats

106 of 121 new or added lines in 3 files covered. (87.6%)

11 existing lines in 1 file now uncovered.

364 of 432 relevant lines covered (84.26%)

570.0 hits per line