google / OpenSK / 39747792305

97%

2.1: 97%

Build Type

push

github

Committed by web-flow

Commit Message

Reject Relying Party IDs that are empty or longer than 253 bytes (#805)

WebAuthn requires the RP ID to be a valid domain string: non-empty, and
capped at 253 bytes in presentation format by RFC 1035, so browsers
never send anything else.

Nothing enforces that for software that talks CTAP directly over USB
HID. A MakeCredential request with rk=true and an empty or longer RP ID
runs the whole ceremony, including the user presence check and the key
generation, and only fails at the very end when storing the
discoverable credential, because the oversized RP ID pushes the
serialized credential past the maximum value size of the persistent
store.

Reject the RP ID upfront instead, right after parsing.

Rebased on develop and reuses MAX_RP_ID_LENGTH from data_formats (now
pub(crate)), which was introduced for the setMinPINLength RP IDs.

Co-authored-by: 17krishna8 <17krishna8@users.noreply.github.com>

Coverage Stats

41 of 41 new or added lines in 1 file covered. (100.0%)

19 existing lines in 1 file now uncovered.

14526 of 14910 relevant lines covered (97.42%)

4017.83 hits per line