CyclopsMC / CyclopsCore / 39737385785

31%

master-1.21: 31%

push

github

Make SingleCache#get thread-safe (#257)

PacketCodec caches its codec fields in a SingleCache. When the same packet instance is
encoded concurrently on several Netty threads (e.g. a packet broadcast to many players),
a thread could observe initialized == true while value was still null, causing an NPE in
PacketCodec#loopCodecFields and disconnecting the player.

Closes #256

1320 of 4627 branches covered (28.53%)

Branch coverage included in aggregate %.

3942 of 12126 relevant lines covered (32.51%)

1.59 hits per line