hyperledger / fabric-x-orderer / 39721047803

85%

Build Type

push

github

Committed by web-flow

Commit Message

request: store the payload before publishing the id in tryInsert (#1260) (#1320)

* request: store the payload before publishing the id in tryInsert (#1260)

tryInsert published reqID2Bucket[reqID] before storing the payload, so a
concurrent removeRequest in that window found the live bucket, missed the
payload, and neither removed nor tombstoned the request. Submit then stored
it and returned nil, leaving a removed request pooled with its permit.

Store the payload and size first and publish the id last, rolling back if
the id is already known (held or tombstoned).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Signed-off-by: Hagar Meir <hagar.meir@ibm.com>

* request: decide pending-store request ownership through the id entry (#1260)

The previous commit stored the payload before publishing the id, but its
rollback could still be reached through a stale id entry that pointed at
the same bucket while a concurrent delete was in progress. A second
remover then deleted the rolled-back payload, so OnDelete ran twice (one
permit released too many) and the bucket size underflowed.

Make the reqID2Bucket entry the only place where ownership is decided:
- removeRequest swaps in a tombstone, and only the caller that swaps out
  a live bucket deletes the payload and calls OnDelete. Removing a held
  request now tombstones it as well, so a late redelivery of a processed
  request is rejected instead of being pooled again.
- Prune erases the id with CompareAndDelete(id, b) before deleting, which
  keeps resubmission after a prune possible.
- bucket.delete only removes the payload and decrements size.
- tryInsert rejects already-known ids before touching the bucket.
- garbageCollectProcessed uses CompareAndDelete so it cannot drop a
  tombstone that a later removal replaced.

The race test now runs NumCPU concurrent submits and removals per trial
and checks that accepted submits and OnDelete calls match.

Co-Authored-By: Claude Opus 5.5 (1... (continued)

Coverage Stats

19 of 19 new or added lines in 2 files covered. (100.0%)

39 existing lines in 6 files now uncovered.

18392 of 21725 relevant lines covered (84.66%)

50214.96 hits per line