• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

valkyrjaio / valkyrja-php / 39718659712
100%

Build:
DEFAULT BRANCH: 26.x
Ran 22 Oct 2026 03:48AM UTC
Jobs 1
Files 1455
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Oct 2026 03:46AM UTC coverage: 100.0%. Remained the same
39718659712

push

github

web-flow
[Queue] fix: Settle through a client that holds the job in process (#1392)

# Description

`InternalQueue` settles a job through the client that sent it, and it
decided
which clients those were by testing for the `InternalClient` abstract.
That
abstract means something narrower than the rule: it is the base for a
client
that drives an entry, and it takes the entry class to drive.
`InMemoryClient`
drives nothing — a caller drains its buffer and feeds the entry — so it
failed
the test and its jobs settled not at all. A retry on one went nowhere.

The rule the entry wants is narrower than redelivery ownership: whether
the
client itself holds the job. A new `InternalClientContract` declares
`settle()`,
the three clients that hold a job in this process implement it, and the
entry
tests for that instead. `RedisClient` and `DatabaseClient` are
redelivered by
the framework too, and do not carry it, because their entries write to
the
store and call `ClientContract::requeue()` directly.

The guard stays, because the four broker clients refuse a requeue: their
processor owns redelivery, and publishing again would duplicate a
delivery that
is still unacknowledged. Settling one would throw rather than redeliver.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Queue\Client\Manager\Contract\InternalClientContract`** — added;
declares
  the settlement an entry performs through a client.
- **`Queue\Client\Manager\Abstract\InternalClient`** — declares the
contract it
  already satisfied.
- **`Queue\Client\Manager\InMemoryClient`** — settles a retry back into
its own
  buffer.
- **`Application\Entry\Abstract... (continued)

4 of 4 new or added lines in 2 files covered. (100.0%)

16529 of 16529 relevant lines covered (100.0%)

30.93 hits per line

Jobs
ID Job ID Ran Files Coverage
1 39718659712.1 22 Oct 2026 03:48AM UTC 1455
100.0
GitHub Action Run
Source Files on build 39718659712
  • Tree
  • List 1455
  • Changed 3
  • Source Changed 3
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #39718659712
  • df221607 on github
  • Prev Build on 26.x (#39460678775)
  • Next Build on 26.x (#39719062312)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc