google / openhtf / 39710696219

65%

master: 65%

Build Type

Pull #1344

github

Committed by copybara-github

Commit Message

Support PhaseSequence, PhaseGroup, and nested PhaseGraph as PhaseGraph nodes.

Lets a PhaseGraph express independent lanes, e.g. two PhaseSequences that run concurrently after a fork, or a PhaseGroup lane whose teardown is guaranteed even when a sibling lane fails.

- Widen PhaseGraph nodes from PhaseDescriptor to any PhaseNode. Collection nodes must be named (UnnamedNodeError) because prerequisites are keyed by node name.
- Dispatch graph nodes through _execute_node() so sequences, groups, and nested graphs run with their usual semantics on the worker thread.
- Scope cancellation to the graph: when a node is terminal (outside teardown) the graph's cancellation event is set, unstarted nodes are cancelled, and running phases are killed, but the stop state is reset immediately so PhaseGroup nodes still unwinding on worker threads run their teardown phases. _execute_abortable_sequence() and _execute_phase() consult the per-thread cancellation scopes (alongside the test abort flag) so cancelled lanes do not start further non-teardown phases.
- Replace the teardown RLock with a counter-based _TeardownGuard so teardown sequences may run concurrently on worker threads (an RLock held by the scheduling thread would deadlock a PhaseGroup node's teardown inside a teardown graph); aborts still never cancel in-progress teardown phases.
- Add unit tests for collection nodes in the data model (naming, copies, nesting, transforms, filter_by_type) and in the executor (fork/join with sequence and group lanes, nested graphs, group teardown surviving sibling failure and abort, a sequence lane stopping after sibling failure, and a group node inside a teardown graph).

PiperOrigin-RevId: 999072646

Pull Request Pull Request #1344: Support PhaseSequence, PhaseGroup, and nested PhaseGraph as PhaseGraph nodes.

Coverage Stats

148 of 158 new or added lines in 2 files covered. (93.67%)

40 existing lines in 3 files now uncovered.

5195 of 7977 relevant lines covered (65.12%)

2.6 hits per line