libbitcoin / libbitcoin-system / 39704641098

97%

push

github

Consensus: treat witness of empty elements as present in witness::skip.

witness::skip reported a witness as superfluous unless some element had
non-zero length, so a stack such as [""] was treated as no witness. On the
wire/view deserialization path (transaction_view, and transaction when
witnesses are skipped) this invalidated the tx, while input::set_witness
and bitcoind (HasWitness) treat any non-empty stack as a witness. Only an
empty stack (count zero) is superfluous [bip144].

4 of 4 new or added lines in 1 file covered. (100.0%)

20382 of 20960 relevant lines covered (97.24%)

2935302.67 hits per line