solidjs / solid / 39701755599

78%

main: 89%

push

github

fix: a throwing cleanup no longer aborts the rest of the teardown (#4213)

* fix: a throwing cleanup no longer aborts the rest of the teardown

Every cleanup in the tree runs even when one throws: the ones registered
before it on the same owner, unvisited siblings, ancestors and effect
cleanups. The first error is rethrown once the teardown is over.

Client (@solidjs/signals): one guarded call (`runCleanup`) covers both the
`_disposal` list and the effect `_cleanup`, collecting the first error.
Outside a flush the walk that began the teardown rethrows it; inside a flush
(a commit retiring a frame, a pass replacing an uncommitted one, an effect
disposing a root) `flush()` rethrows it after the drain completes, so the
commit loop and the effect queues are never left half-applied and the pass
that tears down a frame still drains the lazy releases it collected
(#4176's follow-up case now passes without a dedicated drain).

Server (solid-js): `disposeOwner` guards each child walk and each cleanup
and rethrows the first error after the walk, so renderToStream's final
dispose runs every cleanup and #4206 still reports the error (#4193).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* chore(size): re-record caps for #4213 from CI

Every scenario the change grows, at CI's measured sizes. Hello world
(app: compiled floor) is 9,928 B brotli, under 10 KB.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

* perf(signals): keep the cleanup rethrow off disposeChildren's hot path

CodSpeed flagged createOwners at -10%: the end-of-walk rethrow check in
disposeChildren slowed every disposal. Root dispose now rethrows after its
walk outside a flush; every other teardown leaves it to the flush that
runCleanup schedules. Drops the nested parameter too.

Co-Authored-By: Claude Opus 5.5 ... (continued)

762 of 1055 branches covered (72.23%)

Branch coverage included in aggregate %.

1105 of 1349 relevant lines covered (81.91%)

27.48 hits per line