uber / h3-go / 39673136563

100%

push

github

h3: replace the cgo binding with the pure-Go implementation (#174)

The pure-Go port that lived in x/h3go becomes the root package, and the
cgo binding, its tests and the 43 vendored C files are deleted; the x tree
is gone. The port's own tests move with it and cover every statement. The
public API is the one the binding had, with two differences: the
misspelled ErrRsolutionMismatch is replaced by ErrResolutionMismatch, and
ContainmentMode is a uint32 rather than a cgo integer type. Behaviour
differences from the binding, listed in the README, are the ones the port
was always meant to have: no zero placeholders in set-valued results, no
panics on empty compact inputs or out-of-range resolutions, a different
order of cells around pentagons and in polygon fills, and coordinates that
differ from the C build in their last bits within the conformance bounds.

The conformance runner imports the root package. The two environment
variables with an H3GO_ prefix become H3_INVARIANTS_MAXRES and
H3_EXACT_PROJECTION_MAXRES, matching the H3_CONFORMANCE_ ones; only the
nightly workflow set them. The root benchmarks keep their own polygon
fixture now that the binding's test file is gone, and BenchmarkNumCells
joins them. update-h3.sh now moves the third_party/h3 submodule to a tag
instead of copying sources, and .gitattributes goes with the C it marked
as binary. The lint exclusion for the port's constants follows it to the
root, and third_party is excluded from linting.

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>

1 of 1 new or added line in 1 file covered. (100.0%)

3660 of 3660 relevant lines covered (100.0%)

5181729.8 hits per line