ponder-lab / Hybridize-Functions-Refactoring / #3719

90%

Build Type

push

github

Committed by web-flow

Commit Message

Don't guess a definition by name from PyDev's global index (#1144)

* Don't guess a definition by name from PyDev's global index

When HFR can't follow a name to its definition, PyDev's find-definition
falls back to matching the bare name against its global token index. That
guesses by name alone and can pick an unrelated definition. Turn the
fallback off so such names stay unresolved and are reported as such.

Part of #1121.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Drop the catch the fallback alone could reach

PyDev throws `TooManyMatchesException` only from the global-index fallback,
which the lookup now turns off. Remove its catch and the exception
constructor that wrapped it, and say why the `setter` short-circuit is still
needed without the fallback.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

* Stop declaring an exception the lookup no longer throws

With the global-index fallback off, nothing HFR calls throws
`TooManyMatchesException`. Drop it from the processor's constructors,
`createRefactoring` and `startRefactoring`, and drop the handler's catch.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjPjJj2aZy1ZkUD1eAn

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

3 of 4 new or added lines in 2 files covered. (75.0%)

11 existing lines in 3 files now uncovered.

5401 of 6073 relevant lines covered (88.93%)

0.89 hits per line