eclipse-aascw / aas-core-codegen / 39646473479

90%

push

github

Introduce comparisons of strings and booleans (#857)

We transpile the ordering comparisons ``<``, ``<=``, ``>`` and ``>=`` of
strings and booleans to all the targets. The strings are ordered by
their characters (code points) as in Python, not by their UTF-16 code
units, so that, *e.g.*, ``"\U0001F600" < "\uFFFD"`` is false everywhere:

    StringHelpers.CompareByCodePoints(text, "\uFFFD") < 0   // C#
    StringHelpers.compareByCodePoints(text, "\uFFFD") < 0   // Java
    OurCommon.compareByCodePoints(text, "\uFFFD") < 0       // TypeScript
    common::CompareByCodePoints(text, L"\uFFFD") < 0        // C++

Python and Go order the strings natively. The booleans follow
``False < True``, *e.g.*, ``flag.CompareTo(otherFlag) < 0`` in C# and
``ourcommon.CompareBools(flag, otherFlag) < 0`` in Go. We moved
the code-point comparators of the set properties into the string
helpers, and generate them only where the inferred types show
an ordering of strings or booleans.

The type inference refuses to order the enumerations, the classes and
the byte arrays, and the parser refuses the chained comparisons. We test
the comparisons of strings, booleans, integers, floats and lengths
explicitly with the new common meta-model ``comparisons.py``.

296 of 300 new or added lines in 28 files covered. (98.67%)

45987 of 51021 relevant lines covered (90.13%)

2.7 hits per line