solidjs / solid / 39640981220

78%

main: 89%

push

github

feat(web): dev warning when a stateful binding overwrites an uncommitted edit (#4186) (#4205)

Compiled value/checked/selected/muted bindings share their template's
grouped effect, so any re-run re-writes the bound value with no guard
(the signal is the source of truth). When the element holds an edit the
user never committed to the signal, that write erases it. Dev builds now
report this as UNCOMMITTED_INPUT_OVERWRITTEN: before each stateful write
the runtime compares the value against the one it wrote last time and
the element's current state against what that write left there, and
warns once per element and property when an unchanged value is about to
be re-applied over a user edit. The write itself is unchanged.

- Dev DOM output (Babel and native compiler alike) writes stateful props
  through a new setStatefulProperty helper; production output keeps the
  inline assignment byte for byte. Hydratable output already goes through
  setProperty, which now carries the same dev check, as does the
  spread/assign path. The check folds out of the prod and observe builds;
  the prod entry keeps a two-line stub export, tree-shaken from every
  size scenario (0 B change).
- New diagnostic code, documented in 08-dev-diagnostics, the
  reactivity-diagnostics skill and diagnostics.json.
- The Form inputs docs (07-dom, CHEATSHEET, solid-2.0 skill) now name
  the grouped-effect re-run, link the code, and drop equals: false as a
  way to reject input in favor of e.currentTarget.value = next.
- New dom-dev fixture suite for both compilers plus a parity mode.


Claude-Session: https://claude.ai/code/session_015hPxMkC3jg3Uivh65gvaf2

Co-authored-by: Claude <noreply@anthropic.com>

762 of 1055 branches covered (72.23%)

Branch coverage included in aggregate %.

1105 of 1349 relevant lines covered (81.91%)

27.54 hits per line