loopbackio / loopback-next / 39641740102

55%

Build Type

push

github

Committed by dhmlau

Commit Message

fix: support compiling with TypeScript 6 and 7

Packages depend on TypeScript 6 as `typescript`, matching `@loopback/build`.

Source changes required by TypeScript 6/7:

- The default resolver for `module: commonjs` honors `exports` maps, so
  `@loopback/graphql` no longer imports `Middleware` from a deep `type-graphql`
  path and declares it instead. `GRAPHQL_CONTEXT_RESOLVER` gets an explicit
  type, since its inferred type is not portable (TS2883).
- Reading a parent class field through `super` is an error (TS2855), so
  `@loopback/cron` calls `fireOnTick` through `BaseCronJob.prototype`.
- Declaration emit no longer adds `/// <reference path>` for ambient files, so
  `@loopback/testlab` exports the should.js types from a module rather than a
  global declaration file. Without it, `expect` resolves to `any` in every
  consuming package and api-extractor cannot follow the `Internal` symbol.

With TypeScript 6 type information, typescript-eslint reports more findings:

- Async Express handlers in `@loopback/rest` and the rpc-server example pass
  rejections to `next` (`no-misused-promises`).
- `??` / `??=` replace `||` and `!x` guards on objects and arrays
  (`prefer-nullish-coalescing`). `||` is kept where the operand may be `''`.
- `transactions.suite.ts` awaits `disconnect()` (`no-floating-promises`).

Test defects surfaced by the stricter compiler are fixed as well:
`belongs-to-repository-factory.unit.ts` never assigned `companyRepo` and
clobbered `customerRepo` instead, and the todo-list repository tests used
repositories they never created.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Raymond Feng <enjoyjava@gmail.com>

Coverage Stats

3445 of 10784 branches covered (31.95%)

Branch coverage included in aggregate %.

11 of 17 new or added lines in 8 files covered. (64.71%)

73 existing lines in 2 files now uncovered.

9086 of 11972 relevant lines covered (75.89%)

1361.23 hits per line