umputun / revdiff / 39639032595

92%

push

github

fix(diff): show submodules as a summary row and never mark them reviewed (#403)

A submodule change rendered as ordinary "Subproject commit" add/remove rows,
so each submodule scored +1 -1 and could be marked reviewed, with the mark
surviving a reload. The git renderer now replaces those rows with one
placeholder row flagged IsSubmodule, after confirming the 160000 gitlink mode
through git diff --raw for the same comparison; the rows alone cannot tell a
submodule from a regular file holding that text, and a dirty submodule whose
pointer has not moved carries no mode in its patch. --submodule=short keeps a
diff.submodule=log setting from changing the rows. Empty parsed diffs trigger
the raw check only for renames or combined merge-conflict patches, and an
unresolved submodule merge conflict reads as such.

The row is a context placeholder, so it adds nothing to the counts. Marking a
submodule reviewed is refused with a status-bar hint on every path: the
displayed file, a file not loaded yet, and a file loaded earlier.

Fixed #350

87 of 94 new or added lines in 7 files covered. (92.55%)

12099 of 13236 relevant lines covered (91.41%)

3449.6 hits per line