NVIDIA / nodewright / 39633723090

84%

Build Type

push

github

Committed by web-flow

Commit Message

fix(cli): clear Status.ConfigUpdates on a full nodewright reset (#809)

* fix(cli): clear Status.ConfigUpdates on nodewright reset

A reset removes every node's state but left the per-package config
update keys behind. With them present HasInterrupt ignores a package's
own interrupt, so the restarted run could finish without running it.

A full reset clears status.configUpdates; reset --package clears only
that package's keys. Both run after every node reset succeeded, and not
on --dry-run. A missing NodeWright is ignored, other patch failures warn.

Fixes #776

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

* docs(cli): describe when reset clears config updates

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

* fix(cli): keep configUpdates when another version of the package remains

reset --package name:version cleared configUpdates[name], which is keyed by
name only, while nodes could still hold another version of the package.
Skip the clear in that case, and reword the docs and help to match.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

* fix(cli): satisfy gocyclo and lll in the package reset

Move the still-held check out of runPackageReset and wrap a long test line.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Signed-off-by: Noah Kontur <nkontur@nvidia.com>

---------

Signed-off-by: Noah Kontur <nkontur@nvidia.com>
Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-authored-by: Brian Lockwood <lockwobr@gmail.com>

Coverage Stats

35 of 37 new or added lines in 1 file covered. (94.59%)

16 existing lines in 1 file now uncovered.

10100 of 12081 relevant lines covered (83.6%)

7.61 hits per line