UI5 / cli / 39617741234

94%

Build Type

push

github

Committed by matz3

Commit Message

fix(builder): Skip minify of a .js with an existing -dbg.js sibling

A -dbg.js next to its .js in the sources is unexpected: the minify task
owns the -dbg.js path and generates it from the .js. The glob matched
both as separate map-step keys. The .js key wrote its generated debug
variant to the -dbg.js path, which the -dbg.js key also wrote - two
concurrent keys writing one path, which the shared assertDistinctWrite
guard rejected, so the build crashed.

To stay robust rather than crash, filter the step keys to skip both
members of such a pair: a .js whose -dbg.js sibling already exists is
left as it is (that -dbg.js already serves as the debug variant), the
-dbg.js is passed through, and a warning is logged. The sibling paths
are derived with the shared getDebugName and getNonDebugName helpers, so
the special .view.js / .controller.js suffixes are handled consistently.

The warning states that sources normally must not contain a -dbg.js, but
if the pairing is intentional (for example the file uses ECMAScript
syntax the minify task does not support yet), the user should list both
files in the "builder.minification.excludes" configuration of the
project's ui5.yaml.

The integration test reproduces the crash and pins the expected skip;
unit tests cover the filter and the warning.

JIRA: CPOUI5FOUNDATION-1388

Coverage Stats

7791 of 8576 branches covered (90.85%)

Branch coverage included in aggregate %.

13 of 13 new or added lines in 1 file covered. (100.0%)

1 existing line in 1 file now uncovered.

14854 of 15456 relevant lines covered (96.11%)

5188.94 hits per line