supabase / supautils / 39607907370

95%

push

github

feat: default extension install schema via search_path prepend (#251)

* feat: default extension install schema via search_path prepend

Add supautils.default_extension_install_schema. When set and the target
schema exists, CREATE EXTENSION runs with the schema prepended to
search_path and the original value restored right after the statement.
Native resolution keeps precedence: control-file pins, an explicit
SCHEMA clause and extensions_parameter_overrides all win. On error the
transactional GUC rollback restores search_path, so no PG_TRY is
needed. PGC_SUSET like restrict_extension_versions.

* save and restore search_path via a GUC nest level

Replaces the manual save/restore with NewGUCNestLevel +
set_config_option(GUC_ACTION_SAVE) + AtEOXact_GUC, the same pattern
core's execute_extension_script uses. This also restores the GUC's
scope, so a SET LOCAL search_path before create extension still
reverts at commit instead of being promoted to session level.

* test: default schema applies to cascaded extension installs

Extensions installed via create extension ... cascade are created by
core directly without going through process utility, so statement-level
mechanisms never see them. The search_path default still applies since
core's schema fallback reads the GUC during the whole statement.

* address review: drop unneeded volatile, void-cast set_config_option, reword GUC description

* test: cover search_path-manipulating custom scripts and tle dependency chains

* restore volatile with a comment: gcc -Wclobbered false positive errors under -Werror in CI

* test: exercise search_path manipulation via the global before-create script too

* test: the guc save/restore brackets only search_path, other script-set gucs keep their values

* docs: document default_extension_install_schema in the README

11 of 12 new or added lines in 2 files covered. (91.67%)

1220 of 1289 relevant lines covered (94.65%)

838.67 hits per line