supabase / supabase-flutter / 39601146684

94%

push

github

feat(typegen)!: read geometric columns into value types (#1998)

## Summary

The geometric columns generated `String` getters, and their column
tokens offered the text filters, which fail on these types with 42883.
Each type now maps to a value type of its own in `supabase_common`,
re-exported from postgrest:

| Postgres | Dart | Literal |
| --- | --- | --- |
| `point` | `PostgresPoint(x, y)` | `(1.5,-2)` |
| `line` | `PostgresLine(a, b, c)` | `{1,-1,0}` |
| `lseg` | `PostgresLineSegment(start, end)` | `[(0,0),(1,1)]` |
| `box` | `PostgresBox(corner, oppositeCorner)` | `(2,3),(0,0)` |
| `path` | `PostgresPath(points, isClosed:)` | `[(0,0),(1,1)]` open,
`((0,0),(1,1))` closed |
| `polygon` | `PostgresPolygon(points)` | `((0,0),(1,1),(1,0))` |
| `circle` | `PostgresCircle(center, radius)` | `<(1,2),3>` |

Details:

- **Box corners:** `PostgresBox` stores its `upperRight` and `lowerLeft`
corners the way Postgres normalizes them, so `(0,0),(2,3)` and
`(2,3),(0,0)` are equal.
- **Coordinates:** `parse` reads the spellings Postgres prints (`1e+20`,
`1e-07`, `Infinity`, `NaN`). `literal` writes whole numbers without a
fraction, as Postgres does.
- **Lists:** `PostgresPath` and `PostgresPolygon` keep an unmodifiable
copy of their points.
- **Shared parsing:** all seven types share one pattern-based point
reader.

All seven implement `PostgresValue`, so filters and writes need no
postgrest change.

Two server limitations are documented on the types and in the typegen
README:

- Postgres has no `=` operator for `point` or `polygon`, so an `eq`
filter on those columns fails on the server.
- `=` on `box` compares areas.

## Breaking change

Regenerated getters for these columns change from `String` to the value
types, and the text filters are no longer offered on them.

## Tests

- Unit tests for each type: parse, literal, malformed input, the open
and closed path forms, box corner normalization, and unmodifiable
points.
- Parser test, seven fixture columns, rege... (continued)

145 of 182 new or added lines in 3 files covered. (79.67%)

10551 of 11492 relevant lines covered (91.81%)

5.38 hits per line