i18next / i18next / 39563476231

96%

push

github

fix: replace the matched placeholder, not an earlier copy inside a value (#2454)

interpolate() wrote each value with str.replace(match[0], ...), which
replaces the first copy of the placeholder text. When an earlier value
carries a later placeholder (default skipOnVariables: true), the later
value landed inside that earlier value and the real placeholder stayed
raw:

  t('{{a}} and {{b}}', { a: '{{b}}', b: 'B' })  // 'B and {{b}}'

The value is now sliced in at match.index, as nest() already does, so
this gives '{{b}} and B'. Slicing also keeps `$` patterns literal, so
regexSafe is no longer needed.

1316 of 1458 branches covered (90.26%)

1 of 1 new or added line in 1 file covered. (100.0%)

1286 of 1350 relevant lines covered (95.26%)

1995.47 hits per line