opendefensecloud / artifact-conduit / 39560800224
86%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 17
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.02% (-0.5%) from 86.508%
39560800224

push

github

web-flow 
ci: auto-approve Renovate PRs and require lint/test (#528)

## What
Auto-approves unchanged Renovate PRs and makes Go `lint`/`test` required
checks, so approved Renovate PRs only merge with green CI.

## Why
Rolls out the Renovate auto-approve that solution-arsenal already uses
(opendefensecloud/odd-internal#99). Until now only `check` and `CodeQL`
were required, so an approved PR could merge without lint or tests.

## Testing
`actionlint` is clean on the changed workflows. The skip logic can only
be tested in CI; this PR changes `golang.yaml`, so lint and test run on
it.

## Notes for reviewers
- `renovate-auto-approve.yml` is the dev-kit v3.1.0 stub, the same as
solution-arsenal's.
- Golang CI now always starts. A new `changes` job skips lint/test when
no Go or build files changed, so docs-only PRs still pass the required
checks. If `changes` fails, lint/test run anyway.
- The Helm lint job now reports as `helm-lint`, so the required `lint`
check only means Go lint.
- Until opendefensecloud/dev-kit#62 is fixed, removing `automerge` does
not revoke the auto-approval. To stop a Renovate PR, add the `security`
label.
- Repo admin, before merge: confirm "Allow GitHub Actions to create and
approve pull requests" is on.
- Repo admin, after merge: run `make repo-settings` so `lint`/`test`
become required.

## Checklist
- [x] Tests added/updated, or confirmed that no tests are required
- [x] No breaking changes, or upgrade path documented above
- [x] Readable commit history (squashed and cleaned up as desired)
- [x] AI code review considered and comments resolved


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **CI/CD Improvements**
- Continuous integration now evaluates relevant changes across pushes
and pull requests.
- Linting and tests run in sequence, with required checks covering
validation, linting, testing, and security analysis.
  - Helm linting now reports under a clearly identified check na... (continued)

1409 of 1638 relevant lines covered (86.02%)

1911.12 hits per line

Coverage Regressions

Lines Coverage ∆ File
6
81.82
-2.73% pkg/controller/workflow_handler.go
4
79.68
0.0% pkg/controller/order_controller.go
2
83.43
-1.1% pkg/controller/artifactworkflow_controller.go
Jobs
ID Job ID Ran Files Coverage
1 39560800224.1 17
86.02
GitHub Action Run
Source Files on build 39560800224