• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

valkyrjaio / sindri-php / 39555936217
100%

Build:
DEFAULT BRANCH: 26.x
Ran 21 Oct 2026 06:32AM UTC
Jobs 1
Files 87
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

21 Oct 2026 06:31AM UTC coverage: 100.0%. Remained the same
39555936217

push

github

web-flow
[Cli] fix: Emit the real routing data class from the generator (#354)

# Description

`AstCliDataFileGenerator::generateClassContents()` names a class that
exists
nowhere.

It builds `new \Sindri\Cli\Data\CliRoutingData(...)`, and the real class
is
`Valkyrja\Cli\Routing\Data\CliRoutingData`, which the same file already
imports
and already uses correctly twenty lines further down. An application
calling the
public method therefore gets a string it cannot instantiate. The
generated file
itself is unaffected, because it comes from `generateFileContents()`.

A class named by a string literal is what let this sit unnoticed: no
rename, no
analyzer and no architecture rule follows text. The PHP guide forbids it
for
that reason, and the other four generators all take the class reference.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Generator\Ast\Cli\AstCliDataFileGenerator`** — takes the class
reference
  rather than a string literal.
- **`AstCliDataFileGeneratorTest`** — asserts against the same
reference, so a
  rename moves both.

1 of 1 new or added line in 1 file covered. (100.0%)

1877 of 1877 relevant lines covered (100.0%)

20.07 hits per line

Jobs
ID Job ID Ran Files Coverage
1 39555936217.1 21 Oct 2026 06:32AM UTC 87
100.0
GitHub Action Run
Source Files on build 39555936217
  • Tree
  • List 87
  • Changed 1
  • Source Changed 1
  • Coverage Changed 0
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #39555936217
  • daeb1f5b on github
  • Prev Build on 26.x (#39521507402)
  • Next Build on 26.x (#39558050002)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc