dg / dresscode / 39542709967

97%

Build Type

push

github

Committed by dg

Commit Message

upgrading: the data of PHP are those of the package php, and an upgrading file is a class of its own

What PHP retired is src/Rules/Upgrading/php.neon read as the upgrading data of the platform
package `php`, cut by the target of PHP as a package is by its constraint and laid where
`upgrading.api.phpData` is `yes`, which the standard nette and the set deprecations say. A
call doing nothing since a version earlier than its deprecation stands in the section of
the deprecation with `from`, so no name stands in two maps. NoDeprecatedPhpCallsRule,
NoDeprecatedPhpConstantsRule, PhpUpgradingData and the decisions php.deprecatedCall,
deprecatedCallExcept, deprecatedConstant and deprecatedMember are gone; the values of
arguments PHP deprecated, which no map can name, are NoDeprecatedPhpArgumentsRule under
upgrading.php.deprecatedArgument.

An upgrading file is read and checked by Config\UpgradingFile and laid out for a constraint
by selectFor(). The data keep the words of the file and the version that retired an entry
beside them (UpgradingData::$retirements), which ends its sentence only where the data are
laid (buildDecisions(), shared by ConfigResolver and RuleTester), so UpgradingTester checks
the sentence its author wrote. The versions of PHP are a property of ProjectPackages of its
own (withPhp()), a section counts as unreached only where something in it is not rewritten,
Rewrite::write() spells the global functions of a template for both rules, FunctionPattern
keeps the name as the key writes it, and a call standing as a statement is taken with the
statement, which removing it takes out.

Coverage Stats

218 of 222 new or added lines in 16 files covered. (98.2%)

56 existing lines in 11 files now uncovered.

24741 of 25349 relevant lines covered (97.6%)

0.98 hits per line