omniauth / omniauth / 39538121793

100%

push

github

Skip duplicating the strategy for requests that aren't its own

Every strategy is a middleware that sees every request, and #call dups
the strategy and its options before #call! looks at the path. On a
request that isn't on the strategy's paths, that copy is all it does.

#call now asks the strategy's own on_auth_path? first, on a copy that
shares the options instead of duplicating them, so the path methods
memoize on it rather than on the shared instance. If env isn't on the
strategy's paths, the request goes straight to the app.

It only does so when the path alone decides what #call! would do: a
session is present, test mode is off, there's no other_phase, the
request and callback paths aren't lambdas, and #call!, #phase_call,
#options_call?, #request_call?, and #on_auth_path? are OmniAuth's own.

185 of 185 branches covered (100.0%)

16 of 16 new or added lines in 2 files covered. (100.0%)

660 of 660 relevant lines covered (100.0%)

120.85 hits per line