kubeflow / mcp-server / 39494382826
87%

DEFAULT BRANCH: main
Ran
Jobs 3
Files 38
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 86.921% (+0.02%) from 86.901%
39494382826

push

github

web-flow 
fix(core): thread circuit breaker generation and release slots in execute_tool (#338)

* fix(core): thread circuit breaker generation and release slots in execute_tool

`execute_tool()` in progressive and semantic modes bypassed the circuit
breaker generation-staleness guard by using `can_execute()` (which discards
the generation integer) and passing `generation=None` to recording methods.
It also incorrectly recorded neutral error results as successes instead of
releasing the half-open probe slot.

Migrate `execute_tool()` to `acquire()`, thread the generation into
`record_success()`, `record_failure()`, and `release()`, aligning behavior
with `_audit_wrap()`.

Signed-off-by: Aditya Raut <rautaditya2606@gmail.com>

* fix(core): deduplicate circuit breaker outcome recording into record_tool_result helper

Extract the duplicated circuit breaker recording logic from _audit_wrap in server.py and execute_tool in dynamic_tools.py into a shared record_tool_result() helper in constants.py alongside is_infrastructure_error(). This prevents logic drift between standard and dynamic execution modes.

Signed-off-by: Aditya Raut <rautaditya2606@gmail.com>

* fix(core): move record_tool_result outside try in execute_tool

Move record_tool_result() below the try/except block in execute_tool() so that exceptions are strictly caught for tool execution, and wrap the error condition in parentheses in is_success for clarity.

Signed-off-by: Aditya Raut <rautaditya2606@gmail.com>

* test(core): make half-open recovery timeout deterministic in stale probe test

Signed-off-by: Aditya Raut <rautaditya2606@gmail.com>

---------

Signed-off-by: Aditya Raut <rautaditya2606@gmail.com>

2871 of 3303 relevant lines covered (86.92%)

2.61 hits per line

Coverage Regressions

Lines Coverage ∆ File
20
89.89
-0.19% core/server.py
9
75.29
0.43% core/dynamic_tools.py
1
97.92
-2.08% common/constants.py
Jobs
ID Job ID Ran Files Coverage
1 python-3.10 - 39494382826.1 38
86.92
GitHub Action Run
2 python-3.11 - 39494382826.2 38
86.92
GitHub Action Run
3 python-3.12 - 39494382826.3 38
86.92
GitHub Action Run
Source Files on build 39494382826