astronomer / astro-cli / 39491780296

61%

main: 45%

push

github

Spell APC's flags as Astro's: --deployment and --workspace, with the 1.x spellings as aliases (#2400)

* Give APC's commands --deployment and --workspace, with the 1.x spellings as aliases

The Astro Private Cloud tree spells its flags as the Astro tree does. Help
shows --deployment and --workspace; 1.x's --deployment-id and --workspace-id
keep working on every command 1.x had them, hidden, handed to the v2 flag by
a utils.BeforeArgs hook on each APC tree (applyPreferredFlagsIn), so APC's
deploy no longer calls utils.ApplyAliases by hand. A shorthand 1.x gave the
old spelling (-d, -w) is the new one's; the alias has none. The v2 spellings
refuse "", and an alias given "" still means the default.

- --workspace: deployment create, list and adopt; the workspace user, team
  and service-account commands (-w where 1.x had it).
- --deployment: deployment unadopt, airflow upgrade, runtime upgrade and
  migrate, the service-account commands (-d), and the user and team
  commands, where it is the group's persistent flag, as on Astro.
- --deployment beside the Deployment-id argument, which is unchanged, on
  deployment update, delete, hibernate, wake-up and the logs commands. Given
  both, they must name the same Deployment; given neither, the run is a
  usage error before it asks or calls anything.
- --deployment takes an apc link name of the project around the working
  directory, through internal/deploy's ResolveNamed, the resolution APC's
  deploy runs (now taking a Request, so it resolves for a platform and a
  domain); --deployment-id and the argument stay ids.
- -r for --role on deployment user and team add/update, workspace team
  add/update and workspace user update; -d for adopt's --description; -o
  for --output on Astro's astro deploy, as APC's deploy has.

Fix: the deployment team group marked --deployment-id required before it
defined the flag, and dropped the error, so a team command run without one
asked Houston about the Deployment "". --deplo... (continued)

262 of 299 new or added lines in 19 files covered. (87.63%)

41493 of 68496 relevant lines covered (60.58%)

408.43 hits per line