m-lab / autojoin / 39458218669

70%

push

github

feat(handler): log iata.find failures in Register (#101)

* Ensures that service is comptible with machine

If the requested service is "ndt7" or "ndt7_client", then the Autojoin API
should not return, for example, Wehe servers.

Prometheus (well, gcp-service-discovery) queries the Autojoin API for
script-exporter targets for ndt7 e2e testing. The list endpoint should not
return machines running experiments that are not compatible with the requested
service.

* Adds a comment to explain logic behind new code

See the change in this commit to understand what the comment was added for,
which may not have previously been obvious.

* feat(handler): log iata.find failures in Register

When a node registers with an IATA code that is not present in the
ip2location airport dataset (e.g. a metropolitan code like MIL rather
than an airport code like LIN), Register returns a 500 with error type
"iata.find". This branch was the only 500 path in Register that emitted
no server-side log, so the failure was invisible in AppEngine logs and
could only be diagnosed by reading the code and inspecting request URLs.

Add a log line capturing the offending iata code, org, and service so
future occurrences are identifiable directly from the logs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-authored-by: Roberto D'Auria <roberto@measurementlab.net>

2 of 2 new or added lines in 1 file covered. (100.0%)

1256 of 1783 relevant lines covered (70.44%)

0.78 hits per line