supabase / storage / 39455843227

86%

push

github

fix: enforce bucket file size byte limit on chunked binary uploads (#1566)

## What kind of change does this PR introduce?

Bug fix

## What is the current behavior?

Chunked binary upload does not enforce upload limit if content-length is
missing or under reported.

This affects create, update and signed uploads. Multipart, TUS and S3
uploads are not affected.

## What is the new behavior?

Count bytes as they arrive and reject with `EntityTooLarge` if more
bytes than the limit is received.

Add tests to ensure other uploads properly respect the size limit:
multipart uploads without Content-Length, signed uploads, TUS uploads
with a deferred length, and S3 aws-chunked uploads.

7906 of 9761 branches covered (81.0%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 2 files covered. (100.0%)

13553 of 15315 relevant lines covered (88.49%)

866.08 hits per line