solidjs / solid / 39453490003

78%

main: 89%

push

github

fix(signals): a removed row's cleanup can write during teardown (#4165) (#4168)

* fix(signals): cleanups run with no owner, so a removed row's cleanup can write (#4165)

Removing a keyed For row disposed it inside the list's pass, so its
cleanups ran with the list computation as context. A setter there was
rejected as an owned-scope write and halted reactivity in development.
Cleanups (_disposal entries and the final effect-returned cleanup) now run
through runWithOwner(null), untracked.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

* Keep cleanups owned; exempt teardown from the owned-scope write check

Running cleanups with no owner broke getOwner() and getContext inside
them. Instead, the dev-only owned-scope write checks (setSignal,
markRefresh, the store setter) stand down while disposalDepth is raised,
so a cleanup's writes are allowed and production output is unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_018LY7F9czoRqdMEvk2QwPr1

---------

Co-authored-by: Claude <noreply@anthropic.com>

756 of 1050 branches covered (72.0%)

Branch coverage included in aggregate %.

1103 of 1347 relevant lines covered (81.89%)

27.67 hits per line