Altinity / clickhouse-backup / 39449858446

70%

Build Type

push

github

Committed by Slach

Commit Message

Share one cached GCS token across all pooled clients

Every pooled storage.Client built its own credentials and fetched its
own OAuth2 token, so a cold `delete remote` with delete_concurrency=50
opened ~50 parallel TLS handshakes to oauth2.googleapis.com and failed
on loaded CI runners with "auth: cannot fetch token: ... TLS handshake
timeout"; InvalidateObject on delete errors re-created clients and
repeated the storm on every retry.

Credentials are now built once in Connect with a cached token provider.
Each client gets its own shallow copy, because auth/httptransport
overwrites TokenProvider of the passed credentials on every NewClient
call and a shared pointer is a data race.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Coverage Stats

19 of 34 new or added lines in 1 file covered. (55.88%)

25 existing lines in 7 files now uncovered.

20700 of 29443 relevant lines covered (70.31%)

34398.46 hits per line