supabase / supabase-flutter / 39426381035

92%

Build Type

push

github

Committed by web-flow

Commit Message

fix!: throw AccessTokenException when the accessToken callback fails (#1989)

Fixes [SDK-2279](https://linear.app/supabase/issue/SDK-2279).

When the `accessToken` callback threw, postgrest wrapped an `Exception`
in a `PostgrestTransportException`, which reads like a network error and
was retried as one. A thrown `Error` escaped unwrapped. Storage and
functions also reported the failure as a transport exception.

The token is now resolved through `resolveAccessToken` in
`supabase_common`, used by both `AccessTokenClient` and the
`AuthHttpClient` of `SupabaseClient`. A callback failure becomes an
`AccessTokenException` with the original error in `cause`, thrown before
anything is sent. It extends `SupabaseException`, so every client's
catch path rethrows it unchanged and none of the retry loops treat it as
retryable. An exception that already is a `SupabaseException`, such as
an `AuthException` from a failed session refresh, is still thrown as is.

`AccessTokenException` is exported from postgrest, storage and
functions, and therefore from supabase and supabase_flutter.
`MIGRATION.md` gets a section, since a catch of the transport exception
no longer matches a token failure.

### Tests

- `supabase_common`: a thrown error is wrapped, a `SupabaseException`
passes through, and nothing is sent in either case.
- postgrest, storage and functions: a throwing callback fails with
`AccessTokenException`, reaches no transport, and with retries enabled
is called once.
- supabase: the existing token-failure test now asserts
`AccessTokenException`.

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Access-token callback failures now stop requests before they are sent
and are not retried.
* Failures are reported as `AccessTokenException` with the original
error preserved.
  * Existing Supabase exceptions continue to be rethrown unchanged.

* **New Features**
* `AccessTokenException` is now publicl... (continued)

Coverage Stats

8 of 12 new or added lines in 3 files covered. (66.67%)

15 existing lines in 2 files now uncovered.

10192 of 11078 relevant lines covered (92.0%)

5.5 hits per line