devonfw / IDEasy / 39411566214

75%

push

github

#2589: Inject an application-level IdeContext into NlsService from th… (#2648)

* #2589: Inject an application-level IdeContext into NlsService from the GUI

The GUI previously constructed NlsService with a null context, which made
NlsService fall back to lazily creating its own IdeContextConsole at
persistence time -- a service reaching into the environment to build its own
dependency.

Inject an application-level IdeContextConsole bound to the GUI's start
context from GuiStateManager, and remove the now-unused NlsService(Locale)
constructor and the fallback creation. NlsService now always receives its
context via dependency injection. This also fixes a latent issue: the old
fallback built its own start context and discarded the GUI logging context.

Locale handling and IDE_OPTIONS isolation behavior are unchanged.

* #2589: isolate AppBaseTest's NlsService from the real user home

Address review feedback: GuiStateManager now offers an (ideRoot, IdeContext)
overload; the single-arg constructor delegates and derives the context from the
GUI start context. AppBaseTest injects an isolated IdeTestContext (stub System,
throw-away user home) so persisting the locale no longer rewrites the developer's
real ~/.ide/ide.properties.

---------

Co-authored-by: Lukas <luk.faber@gmx.de>
Co-authored-by: quando632 <quang-hieu.do@capgemini.com>

5864 of 8723 branches covered (67.22%)

Branch coverage included in aggregate %.

15336 of 19641 relevant lines covered (78.08%)

3.35 hits per line