mlocati / ocsp / 39421877225

72%

master: 69%

Build Type

push

github

Committed by web-flow

Commit Message

Add support for phpseclib 4 (#20)

* Add support for phpseclib 4

phpseclib 4 moved its classes to the phpseclib4 namespace. Detect it before falling back to phpseclib3 and phpseclib 2, and allow ^4 in composer.json.

* Test against PHP 8.5

curl_close() is deprecated as of PHP 8.5 and has no effect since PHP 8.0, so only call it on older versions.

* Test OCSP against a local test CA

Public CAs are phasing out OCSP, which makes the remote tests unreliable. Add a test CA (with a good and a revoked certificate) and test against it in two ways:
- recorded OpenSSL requests and responses, which need nothing but PHP;
- the OpenSSL OCSP responder answering requests built by this library, skipped when openssl is not available.

test/assets/ocsp/generate.sh regenerates all of these assets.

* Replace google.com in the remote OCSP test

Google's certificates no longer include an OCSP responder URL. Use DigiCert's valid demo certificate instead, and skip the remote test when a certificate has no OCSP responder URL.

* Nest the phpseclib class_exists checks

---------

Co-authored-by: Michele Locati <michele@locati.it>

Coverage Stats

3 of 4 new or added lines in 1 file covered. (75.0%)

1 existing line in 1 file now uncovered.

497 of 690 relevant lines covered (72.03%)

10.51 hits per line