ponder-lab / Hybridize-Functions-Refactoring / #3683

89%

main: 90%

push

github

Decline iterating a tensor parameter through `enumerate` or `zip` (#1103)

* Decline iterating a tensor parameter through enumerate or zip, or assigning into it by index

The tensor-iteration check now also fires when a parameter-derived tensor is
passed to a builtin whose model iterates that argument, and a new
precondition (code 37) declines a subscript store into a parameter-derived
tensor. Both raise under tracing once the parameter is symbolic.

Refs #1098.

* Cite the engine issue for the unmodeled reversed builtin

* Pin string-keyed and multi-index stores into a tensor

A multi-index store is keyed by a tuple and is refused. A string-keyed
store reads as an attribute store in the IR (wala/ML#1100) and is pinned as
converted.

* Move the item-assignment check to its own branch

The subscript-store check needs Ariadne to distinguish a subscript store
from an attribute store in its IR (wala/ML#1100), so it moves to a separate
branch. This branch keeps the enumerate and zip widening of the iteration
check, and its test is renamed to match.

Refs #1098.

* Refuse iterating a tensor parameter through reversed

Ariadne now models reversed as iterating its argument (wala/ML#1099), so
the reversed pin advances from converted to refused with code 20.

* Document the summary-IR shape the builtin iteration check reads

The check fires when a builtin's summary IR holds an EachElementGet over
the parameter, which today covers enumerate, zip and reversed. A summary
re-expressed another way stops the check from firing, in the unsafe
direction, and builtins whose summaries don't iterate their argument are
out of scope.

* Cite the summary-IR contract and the list and sorted engine gap

The builtin iteration check's Javadoc now cites the recorded summary-IR
contract (wala/ML#916), and marks list and sorted as out of scope with a
TODO on wala/ML#1102.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NTnpjP... (continued)

31 of 31 new or added lines in 2 files covered. (100.0%)

5322 of 6000 relevant lines covered (88.7%)

0.89 hits per line