google / OpenSK / 39404633532

97%

2.1: 97%

push

github

Ignores unknown credential descriptors (#809)

Before, `PublicKeyCredentialDescriptor` handling had two issues with
unknown values:

- `AuthenticatorTransport::try_from` rejected any transport string
  other than `"usb"`, `"nfc"`, `"ble"`, or `"internal"` (such as
  `"hybrid"`) with `CTAP2_ERR_CBOR_UNEXPECTED_TYPE`, failing the
  entire command instead of ignoring unknown transport hints.
- Lookups in `excludeList`, `allowList`, and `CredentialManagement`
  only compared `key_id` and did not check that `key_type` is
  `PublicKeyCredentialType::PublicKey`.

We now add `AuthenticatorTransport::Hybrid`, ignore unknown transport
strings in `PublicKeyCredentialDescriptor`, and ignore descriptors
whose type is `PublicKeyCredentialType::Unknown`:
https://fidoalliance.org/specs/fido-v2.3-ps-20260226/fido-client-to-authenticator-protocol-v2.3-ps-20260226.html#sctn-makeCred-authnr-alg

89 of 91 new or added lines in 3 files covered. (97.8%)

14114 of 14505 relevant lines covered (97.3%)

4125.16 hits per line