Unleash / unleash-java-sdk / 39388992495

80%

push

github

perf: skip evaluation events nobody is subscribed to (#387)

* perf: skip evaluation events nobody is subscribed to

Every isEnabled/getVariant call enqueues a ToggleEvaluated task on the
shared UnleashScheduledExecutor, even when the configured subscriber
doesn't implement toggleEvaluated. The enqueue takes the executor's
queue lock, allocates a FutureTask plus queue and condition nodes and
wakes a worker, so all evaluating threads end up contending on one lock.

Every method on UnleashSubscriber is a default no-op, so EventDispatcher
can work out once, at construction, whether an event type reaches
anything: an event is skipped only when the subscriber inherits the
default for both on(UnleashEvent) and the specific callback that event
publishes to. Only ToggleEvaluated and ImpressionEvent are gated, every
other event type always dispatches, and anything that cannot be resolved
counts as overridden so no callback is ever silently dropped.

DefaultUnleash checks isSubscribedTo before constructing the event,
which also skips the UUID.randomUUID() in the ImpressionEvent
constructor.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* refactor: keep the subscription guard inside EventDispatcher

Drop the public isSubscribedTo so callers can't forget to check it.
Per-evaluation events now go through typed dispatch methods that take
the event's fields and only construct the event when something will
receive it, keeping the evaluation path allocation-free for events
nobody listens to.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Meemaw <matej.snuderl@opensea.io>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>

397 of 570 branches covered (69.65%)

Branch coverage included in aggregate %.

30 of 32 new or added lines in 2 files covered. (93.75%)

1781 of 2147 relevant lines covered (82.95%)

6.49 hits per line