polserver / polserver / 39373964661

82%

Build Type

push

github

Committed by web-flow

Commit Message

Fix the UBSan and ASan reports and make sanitizer findings fail CI (#990)

* Read packet fields through memcpy instead of cast pointers
Packet buffers hold u16/u32 fields at odd offsets. Reading or writing
them through reinterpret_cast pointers is undefined
behaviour, which
UBSan reports as misaligned loads and stores. Add
Clib::load_unaligned/store_unaligned and use them in the
packet hooks,
the BPacket get/set methods, custom house packets, speech
tokens and
String::fromUTF16. Copy the proxy protocol header and
payload out of
the receive buffer instead of casting it.

fromUTF16 also read one code unit past `len` when the text
had no null terminator; the bound is now checked first.

* Fix the remaining UBSan reports from the shard tests

- Pool 0xF0 packets per subcommand. A single queue handed a recycled
  party packet (PktOut_F0_Sub01) to the guild query as PktOut_F0_Sub02.
- Compute the client encryption keys in unsigned arithmetic; the formulas overflow int by design.
- Mask the shift count in LoginCrypt::Decrypt_1_25_36 to 5 bits,
  as the client's x86 shift does. Counts of 32 and more are undefined.
  A new test pins the keystream, which is unchanged.
- Give ECryptType and USKILLID a fixed underlying type, so unknown crypt types,
  the -1 "no skill" sentinel and skill ids up to 499 are valid values.

* Turn on more sanitizer checks in CI

Make UBSan fail the job instead of only logging. Enable
libstdc++
assertions in all sanitizer builds and vector
container-overflow
annotations under ASan. Turn on ASan's
stack-use-after-return,
initialization-order and strict string checks.

* Read listing tokens through memcpy instead of cast pointers

StoredTokenDecoder read doubles, ints, uint16_t and
DebugToken from
the program data by casting a pointer at an arbitrary
offset. These
reads are misaligned, which UBSan reports. They now use
Clib::load_unaligned. debug_token_at returns a copy instead
of a
reference into the buffer.

StoredToken is packed. deco... (continued)

Coverage Stats

143 of 150 new or added lines in 16 files covered. (95.33%)

15 existing lines in 5 files now uncovered.

60301 of 73542 relevant lines covered (82.0%)

727669.95 hits per line