• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

valkyrjaio / valkyrja-php / 39371936762
100%

Build:
DEFAULT BRANCH: 26.x
Ran 20 Oct 2026 04:57AM UTC
Jobs 1
Files 1406
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

20 Oct 2026 04:53AM UTC coverage: 100.0%. Remained the same
39371936762

push

github

web-flow
[Queue] fix: Keep a delayed redis job from replacing another (#1386)

# Description

A delayed redis job could disappear on the way to the queue.

The sorted set that holds a delayed job used the envelope as the member,
and a
sorted set keeps one copy of a member. Two pushes of one job instance
inside a
single millisecond therefore wrote the same string twice, and the second
scored
the first rather than joining it, so the queue delivered one of the two
and
reported nothing. Against a real redis this lost a job in 232 of 300
trials.

A member now carries a uniqueness token in front of the envelope, and
the
promote script takes the token back off. The script reads the token by
the
token's own alphabet rather than by the separator, because the separator
is
legal inside an envelope: a job named `Report|Daily` written before this
change
would otherwise promote as a fragment and park as unreadable.

Warning: upgrade the workers before the producers. A worker strips the
token
with the script it was deployed with, so a worker still running an older
one
hands a tokenized member on whole and the ready list cannot read it.

Two pushes of separately constructed jobs were never affected, because
each job
builds its own id, and the ready list was never affected because a list
takes
duplicates.

## Types of changes

- [ ] Improvement _(non-breaking change which improves code)_
- [x] Bug fix _(non-breaking change which fixes an issue)_
- [ ] New feature _(non-breaking change which adds functionality)_
- [ ] Deprecation _(breaking change which removes functionality)_
- [ ] Breaking change _(fix or feature that would cause existing
functionality to change)_
- [ ] Documentation improvement

## Changes

- **`Queue\Client\Manager\RedisClient`** — a delayed member is a token,
a
  separator, and then the envelope.
- **`Application\Entry\Redis\RedisQueue`** — the promote script strips
the
  token, and promotes a member that carries none.
- **`Queue/README.md`** — documented ... (continued)

4 of 4 new or added lines in 2 files covered. (100.0%)

15425 of 15425 relevant lines covered (100.0%)

30.42 hits per line

Jobs
ID Job ID Ran Files Coverage
1 39371936762.1 20 Oct 2026 04:57AM UTC 1406
100.0
GitHub Action Run
Source Files on build 39371936762
  • Tree
  • List 1406
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #39371936762
  • d0ce6155 on github
  • Prev Build on 26.x (#39371795345)
  • Next Build on 26.x (#39373903922)
  • Delete
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE TRIAL · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc