KusionStack / kusion / 39356399022

46%

push

github

ci: migrate golangci-lint to v2 (#1466)

* ci: migrate golangci-lint to v2

golangci-lint v1 is no longer maintained and cannot load modules that
target Go 1.25, which the pending dependency updates need. Move to v2
first, on the current Go version, so the Go bump can follow separately.

- Use golangci-lint v2.14.0 with golangci-lint-action@v9.
- Migrate .golangci.yml to the v2 format and keep the v1 rule set:
  gosimple and stylecheck are now part of staticcheck, gofumpt moves
  to formatters, the QF* quick fixes and govet's inline analyser stay
  off, and v1's default exclusions are kept through presets.
- Skip prealloc in _test.go files, and match third_party, builtin and
  examples directories the way v1 did.
- make lint and lint-fix now install GOLINTER_VERSION when the
  golangci-lint on PATH is missing or a different version, and fail
  with a clear message if an older binary still shadows it.

Co-authored-by: Iamrushabhshahh <rushabhshah842@gmail.com>
Signed-off-by: Iamrushabhshahh <rushabhshah842@gmail.com>

* style: fix findings reported by golangci-lint v2

The linters bundled with golangci-lint v2 report findings that v1 did
not. All are small and do not change behaviour, except the slog calls,
which logged the error as the message and produced a !BADKEY attribute.

- govet slog: logger.Error(err.Error(), "msg", "error", err) becomes
  logger.Error("msg", "error", err).
- staticcheck SA1006: fmt.Errorf(s) becomes errors.New(s), and
  fmt.Printf(s) becomes fmt.Print(s).
- staticcheck S1009: drop nil checks that len() already covers.
- predeclared: rename local "max" variables, which shadow the Go 1.21
  builtin, to "maxItems".
- prealloc: preallocate slices in non-test code.
- gofumpt: reformat k8s_printer.go.

Co-authored-by: Iamrushabhshahh <rushabhshah842@gmail.com>
Signed-off-by: Iamrushabhshahh <rushabhshah842@gmail.com>

---------

Signed-off-by: Iamrushabhshahh <rushabhshah842@gmail.com>

19 of 55 new or added lines in 16 files covered. (34.55%)

11379 of 24558 relevant lines covered (46.34%)

0.51 hits per line